[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Issue 1628

From: SteveKing <steveking_at_gmx.ch>
Date: 2005-07-20 17:49:33 CEST

Branko Čibej wrote:

> I'm not against the idea of a custom crash handler, but the patch as it
> stands is unacceptable:
>
> * it uses C++ comments in C code

Oops. Completely missed that.

> * it uses Hungarian naming convention

And that's bad why? Ok, it's not the Subversion naming convention, got it.

> * the change doesn't belong in clients/cmdline/main.c, but in
> svn_cmdline_init (or a similar function in libsvn_subr/cmdline.c),
> because there are other command-line utilities that could use this
> functionality.

That would be better indeed.

Just note: this patch wasn't intended to be applied directly. That's
also why I didn't provide a log message for it (maybe I shouldn't have
put the [PATCH] in the mail subject). It's simply a patch to show you
how it could be done.
There's still many things to consider:
- the mail address the reports get sent to
- maybe some compiler define to exclude that code part if it's not an
official build - otherwise you'll get reports which you can't really use
because you miss the debug symbols

Stefan

-- 
        ___
   oo  // \\      "De Chelonian Mobile"
  (_,\/ \_/ \     TortoiseSVN
    \ \_/_\_/>    The coolest Interface to (Sub)Version Control
    /_/   \_\     http://tortoisesvn.tigris.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Jul 20 17:51:18 2005

This is an archived mail posted to the Subversion Dev mailing list.