[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r15370 - in branches/python-bindings-improvements/subversion/bindings/swig: python/libsvn_swig_py python/svn

From: David James <james82_at_gmail.com>
Date: 2005-07-20 04:58:09 CEST

On 7/19/05, Philip Martin <philip@codematters.co.uk> wrote:
> > +static char *poolAttribute = (char *) "_pool";
> > +static char *assertValid = (char *) "assert_valid";
> > +static char *emptyTuple = (char *) "()";
>
> Casting away const is generally a bad idea, how about
>
> static char name[] = "value";
I've followed your suggestion in r15371.

By the way, if you take a look at
subversion/bindings/swig/python/libsvn_swig_py/swigutil_py.c, you'll
see that there are lots of unsafe casts throughout the file. Should I
get rid of the unsafe casts by using your suggested technique?

Cheers,

David

-- 
David James -- http://www.cs.toronto.edu/~james
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Jul 20 23:06:19 2005

This is an archived mail posted to the Subversion Dev mailing list.