Re: [PATCH] truncate EDITOR_EOF_PREFIX with previous EOL

Olleg Samoylov wrote:
> Michael W Thelen wrote:
>> Thank you for the patch... this is basically issue #1870:
>> http://subversion.tigris.org/issues/show_bug.cgi?id=1870
>>
>> If you follow the mailing list threads linked from that issue, it
>> appears that there is no clear consensus on whether trailing blank lines
>> in log messages ought to be removed.
>>
> My patch don't change svn log output and don't concern
> http://subversion.tigris.org/issues/show_bug.cgi?id=1870.

Well, it does change svn log output indirectly... the reason I mentioned
issue #1870 is because the patch from Patrik Rådman, linked from that
issue, looks extremely similar to yours. If you haven't already, it
would probably be useful to read the discussion that began as a result
of Patrick's patch. That discussion resulted in the idea that modifying
the output of svn log (by not printing extraneous newlines) is probably
preferable to removing newlines from the log message itself. Thus, the
patch in issue #1870.

-- 
Michael W Thelen
It is a mistake to think you can solve any major problems just with
potatoes.       -- Douglas Adams
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org