Re: svn commit: r15370 - in branches/python-bindings-improvements/subversion/bindings/swig: python/libsvn_swig_py python/svn

David James <james82@gmail.com> writes:

> David James wrote:
>> To make my code more clear, I propose to take the following steps:
>> - Rename the _global_pool variable to svn_swig_application_pool
>> throughout the SWIG bindings (including in the Perl and Ruby bindings)
>> - Add a comment to the source code explaining why I created a global variable.
>>
>> Philip, does this sound like a good solution?

I didn't really understand the explanation.

> Oops. svn_swig_application_pool is a bad name for the variable,
> because it is not only an application pool -- we are forced by
> implementation details to use the same name for local pools. Would the
> name "svn_swig_pool" be better?

Is the pool Python specific? svn_swig_py_pool might be better.

-- 
Philip Martin
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org