[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: REVIEW REQUESTED (was Re: Parseable tracking of code contributions.)

From: Joshua Varner <jlvarner_at_gmail.com>
Date: 2005-07-18 15:31:07 CEST

My Notes have '>>>' in front of them. There were a couple of patterns I noticed.
1. mentions of people with no name and just an e-mail sometimes had <>'s other not. Consistency there would help the scripting.2. Most of the time when you had a 'based on a patch' you listed me as the second author, but about 5 times you didn't3. Every once and a while you used I instead of me.4. Inspired by -> Suggested by5. Analysis by -> Suggested by (I thought that was the conclusion from the earlier thread.6. Forwarded by should maybe be in ()'s rather than on it's own line less noise for scripts to filter (Bikeshed, but just an opinion)7. r10495 seems to have been deleted with no addition
I can't garuntee much coherence by the end of the following list, Iwrote the summary this morning, but I was a bit cross-eyed last nightafter going through these logs.
JoshOn 7/17/05, Branko Čibej <brane_at_xbc.nu> wrote:> kfogel_at_collab.net wrote:> > >I've got all the log message changes ready now. Please review> >> > http://www.red-bean.com/kfogel/changed-revs.utf8> >
+++ NEW/r10069 2005-07-16 12:43:24.000000000 -0500@@ -1,5 +1,7 @@ Fix Issue #1793: Stop 'svn up' from deleting schedule-add target directory.-Patch from S. Ramaswamy <ramaswamy@collab.net>, regression test from me.++Patch by: S. Ramaswamy <ramaswamy@collab.net>+(I wrote the regression test.)
>>> This is the only place you use 'I'. Later you use (Test script by me) which>>> seems more consistent.
                           =*= =*= =*= =*= =*=
--- OLD/r10495 2005-07-16 12:43:24.000000000 -0500+++ NEW/r10495 2005-07-16 12:43:24.000000000 -0500@@ -2,11 +2,3 @@ Approved by: +1: lundblad, sussman, breser--Don't URI-encode pathname in mod_dav_svn.--Patch by Hiroharu Tamaru <tamaru@myn.lcast.u-tokyo.ac.jp>.--* mod_dav_svn/repos.c (dav_svn_deliver): Don't URI-encode path attribute- in index element in XML directory listings.-* STATUS: Remove r10461.

                           =*= =*= =*= =*= =*=
>>> This seems to be a deletion with no corresponding addition

+++ NEW/r10676 2005-07-16 12:43:24.000000000 -0500@@ -1,8 +1,8 @@ Remove segfault introduced in r8984 when committing a renamed file with modified svn:eol-style property. -Patch by Øyvind A. Holm <sunny@sunbase.org>, regression test by-philip.+Patch by: Øyvind A. Holm <sunny@sunbase.org>+(Regression test by philip.)
>>> Should philip be a full name? Maybe>>> Suggestion by: philip-full-name>>> (Created regression test)
+++ NEW/r10781 2005-07-16 12:43:24.000000000 -0500@@ -1,2 +1,5 @@-* www/project_faq.html (case-change): Apply patch from Duncan Murdoch- <subversion@murdoch-sutherland.com>, slightly tweaked by me. +* www/project_faq.html+ (case-change): Make various clarifications. ++Patch by Duncan Murdoch <subversion@murdoch-sutherland.com>+(Tweaked by me.)
                           =*= =*= =*= =*= =*=>>> No colon after Patch by
+++ NEW/r11122 2005-07-16 12:43:24.000000000 -0500@@ -1,3 +1,4 @@ * notes/releases.txt: Add reminder to differentiate between client-- and server-side changes. Thanks to "Leeuw van der, Tim"- <tim.leeuwvander@nl.unisys.com> for the suggestion.+ and server-side changes. ++Suggested by: "Leeuw van der, Tim" <tim.leeuwvander@nl.unisys.com>
>>> This is the only name in quotes (given that's how it was originally)>>> Just odd.
+++ NEW/r11582 2005-07-16 12:43:24.000000000 -0500@@ -1,3 +1,4 @@-* www/project_links.html: Link to objectweb.org. Thanks to - Mathieu Peltier <mathieu.peltier@inrialpes.fr> for suggesting- this, and Jason Robbins <jrobbins@tigris.org> for forwarding.+* www/project_links.html: Link to objectweb.org. ++Suggested by: Mathieu Peltier <mathieu.peltier@inrialpes.fr>+Forwarded by: Jason Robbins <jrobbins@tigris.org>
                           =*= =*= =*= =*= =*=
>>> Non-standard Forwarded by, why not put it in ()'s like the >>> 'tweaked by me' comments?
+++ NEW/r11673 2005-07-16 12:43:24.000000000 -0500@@ -1,7 +1,7 @@ Plug memory leak in UTF-8 routines. -Thanks to Eric Gillespie <epg@pretzelnet.org> for tracing the leak to the new-xlate handle caching.+Analysis by: Eric Gillespie <epg@pretzelnet.org>+He traced the leak to the new xlate handle caching. >>> I thought analysis was decide to be to many divisions, shouldn't this>>> be Suggested By: with the particulars in ()'s on the next line.
+++ NEW/r1188 2005-07-16 12:43:24.000000000 -0500@@ -1,6 +1,8 @@ Fix issue 565, an error during commit when a file that was svn rm'd is-physically deleted before the commit. Patch by Garrett Rooney-<rooneg@electricjellyfish.net>. Minor mods by cmpilato.+physically deleted before the commit. ++Patch by: Garrett Rooney <rooneg@electricjellyfish.net>. +(With minor mods by me.) >>> Why not (tweaked by me.)? I know its bikeshed, but consistency is>>> the goal of this set of changes.
+++ NEW/r12029 2005-07-16 12:43:24.000000000 -0500@@ -1,6 +1,8 @@ Fix issue #1832: Don't use potentially locale-sensitive tests to determine if characters are in a specific subset of the ASCII subset-of UTF8. Thanks to Joe Orton <joe@light.plus.com> for analysis.+of UTF8.++Analysis by: Joe Orton <joe@light.plus.com> >>> same comment about analysis vs. suggested
+++ NEW/r12082 2005-07-16 12:43:24.000000000 -0500@@ -1,5 +1,6 @@ * www/project_links.html: Put "www" on the front of subversionary.org- link, since the site redirects there anyway. Thanks to Martin- Tomes <martin.tomes@eurotherm.co.uk> for the original patch, to- Kenneth Porter <shiva@sewingwitch.com> for noting the redirect,- and to the country of Belgium for the beer.+ link, since the site redirects there anyway. ++Patch by: Martin Tomes <martin.tomes@eurotherm.co.uk>+Review by: Kenneth Porter <shiva@sewingwitch.com>+Beer by: Belgium
>>> Non-standard but definately helped break the tedium
+++ NEW/r12502 2005-07-16 12:43:24.000000000 -0500@@ -1,5 +1,7 @@-Update to svnmirror.sh submitted by John Belmonte <john@neggie.net>-via Martin Furter.+Update to svnmirror.sh.++Patch by: John Belmonte <john@neggie.net>+Forwarded by: Martin Furter >>> same comment about forwarded
+++ NEW/r12745 2005-07-16 12:43:24.000000000 -0500@@ -1,5 +1,7 @@ Make hook templates warn about their impoverished environments,-as suggested by Faheem Mitha <faheem@email.unc.edu> and others.++Suggested by: Faheem Mitha <faheem@email.unc.edu>+ and others >>> Maybe put the other in ()'s since this will make noise in the >>> extracted output of the script (or at least remove and as that>>> is implied by the second line)
+++ NEW/r12883 2005-07-16 12:43:24.000000000 -0500@@ -1,4 +1,5 @@-Based on a patch submitted by Matthew Ford <matthew.ford@forward.com.au>- * www/project_packages.html: Note that Win9x/Me can't host a repository, and link to the FAQ item.++Patch by: me+ Matthew Ford <matthew.ford@forward.com.au>
>>> This is the only time you put me before the originator of the patch
+++ NEW/r12920 2005-07-16 12:43:24.000000000 -0500@@ -5,8 +5,7 @@ encoding as well as the failing string, fuzzily escaped in the same way as we do in the cmdline client. -thanks to Sergey Proskurnya <alaley@gmail.com> for some-inspiration:-).+Inspired by: Sergey Proskurnya <alaley@gmail.com> >>> Suggested By:
+++ NEW/r12983 2005-07-16 12:43:24.000000000 -0500@@ -1,5 +1,7 @@-Treat a Win32 sharing violation as cause for retrying a file op. Based on-a patch by Roland Ruedenauer <roland.ruedenauer@yellow-computing.de>.+Treat a Win32 sharing violation as cause for retrying a file op. ++Patch by: me+ Roland Ruedenauer <roland.ruedenauer@yellow-computing.de> * subversion/libsvn_subr/io.c (WIN32_RETRY_LOOP): Check for ERROR_SHARING_VIOLATION, too.
>>> Okay I lied this is the second time you put me before the originator>>> of the patch
+++ NEW/r13237 2005-07-16 12:43:24.000000000 -0500@@ -1,3 +1,4 @@ * subversion/include/svn_error_codes.h (SVN_ERR_WC_NOT_LOCKED): Add text saying this probably indicates a bug.- Thanks to faxmodem@free.fr for the suggestion.++Suggested by: faxmodem@free.fr
>>> No name but should you put the e-mail in <>'s anyway for consistency?
--- OLD/r13836 2005-07-16 12:43:24.000000000 -0500+++ NEW/r13836 2005-07-16 12:43:24.000000000 -0500@@ -1,7 +1,9 @@ Allow translation of strings with plural forms (for languages with one or two plural forms). -Parts by niqueco and Marcel Gosselin <marcin.gosselin@polymtl.ca>.+Patch by: me+ Nicolás Lichtmaier <nick@reloco.com.ar>+ Marcel Gosselin <marcin.gosselin@polymtl.ca> * subversion/clients/cmdline/log-cmd.c (log_message_receiver), * subversion/clients/cmdline/info-cmd.c (print_info),
                           =*= =*= =*= =*= =*=
>>> me is listed first - only the 3rd time so far
--- OLD/r13885 2005-07-16 12:43:24.000000000 -0500+++ NEW/r13885 2005-07-16 12:43:24.000000000 -0500@@ -1,6 +1,8 @@ Add a function to mod_dav_svn to get the path of the repository on disk. This can be useful for other Apache modules.-Patch by Marcus Rueckert <darix@web.de>. Comments tweaked by me.++Patch by: Marcus Rueckert <darix@web.de>+(Comment tweaks by Max Bowsher <maxb@collab.net>.) >>> This has me confused is me kfogel or is me the commiter?
+++ NEW/r14032 2005-07-16 12:43:24.000000000 -0500@@ -1,5 +1,7 @@ Make the last of our web pages valid "Tigris XHTML 1.0 Transitional".-Joint effort with Markus Rueckert <darix@web.de>.++Patch by: me+ Markus Rueckert <darix@web.de> >>> At this point I'm just noting all of these so, here's another. Idon't remember>>> why or if it's important
+++ NEW/r14064 2005-07-16 12:43:24.000000000 -0500@@ -1,4 +1,4 @@ Fix svn status help text. "*" appears in column 8, not 9.-Reported by Jim Correia <jim.correia@pobox.com>+Reported by: Jim Correia <jim.correia@pobox.com> >>> Suggested By:
--- OLD/r14097 2005-07-16 12:43:24.000000000 -0500+++ NEW/r14097 2005-07-16 12:43:24.000000000 -0500@@ -1,4 +1,5 @@-Fix further GCCisms. Reported by NormW <normw@bocnet.com.au>.+Fix further GCCisms.+Reported by: NormW <normw@bocnet.com.au>
>>> Suggested By:
+++ NEW/r14134 2005-07-16 12:43:24.000000000 -0500@@ -2,6 +2,8 @@ With thanks to Martin Tomes <lists@tomes@org> for the correct CSS incantation to get a block level element centered. +Contribution by: Martin Tomes <lists@tomes@org>+
>>> Patch By:
+++ NEW/r14262 2005-07-16 12:43:24.000000000 -0500@@ -8,8 +8,11 @@ In order to make the PUT part work, set 'ModMimeUsePathInfo on'. In order to make the GET part work, set 'TypesConfig conf/mime.types'. -Patch by cmpilato and sussman, inspired by patch from Dorian Taylor-<dorian@foobarsystems.com>. See issue #2049.+Patch by: C. Michael Pilato <cmpilato@collab.net>+ me+Inspired by: Dorian Taylor <dorian@foobarsystems.com>
>>> Suggested By:
+++ NEW/r14381 2005-07-16 12:43:24.000000000 -0500@@ -1,9 +1,9 @@ Make davautocheck use the apxs specified at configure time and kill Apache on signals. -Parts suggested by offby1.-Patch by VK Sameer <sameer@collab.net>.-Tweaked somewhat by me.+Patch by: VK Sameer <sameer@collab.net>+(Tweaked by me.)+Suggestions by: offby1
>>> possibly put in <>'s since it is an e-mail not a name
--- OLD/r15055 2005-07-16 12:43:23.000000000 -0500+++ NEW/r15055 2005-07-16 12:43:24.000000000 -0500@@ -1,4 +1,4 @@-Add new FAQ item from Greg Thomas <greg.d.thomas@gmail.com>.- * www/faq.html (binary-files): New item, "How does Subversion handle binary files?".++Patch by: Greg Thomas <greg.d.thomas@gmail.com>
                           =*= =*= =*= =*= =*=
--- OLD/r15057 2005-07-16 12:43:23.000000000 -0500+++ NEW/r15057 2005-07-16 12:43:24.000000000 -0500@@ -1,2 +1,3 @@-* www/faq.html: Add "<meta http-equiv=...>" element, as suggested by- Greg Thomas <thomasgd@omc.bt.co.uk>.+* www/faq.html: Add "<meta http-equiv=...>" element.++Suggested by: Greg Thomas <thomasgd@omc.bt.co.uk>
>>> 2 different e-mails for Greg Thomas - 2 different GTs?
+Suggested by: Vivek C. <vivek@collab.net>
>>> I've seen both Vivek and Vivek C.
+++ NEW/r15160 2005-07-16 12:43:24.000000000 -0500@@ -1,4 +1,6 @@-A few fixes to mailer.py. Patch by Servatius.Brandt@fujitsu-siemens.com.+A few fixes to mailer.py.++Patch by: Servatius.Brandt@fujitsu-siemens.com >>> No name - put in <>'s
-Patch from Nuutti Kotivuori <naked@iki.fi>, applied with only minor-tweaks.+Patch by: Nuutti Kotivuori <naked@iki.fi>+(Minor tweaks by me.) >>> Why not just (Tweaked by me.)
+++ NEW/r2622 2005-07-16 12:43:24.000000000 -0500@@ -1,4 +1,3 @@--Patch from epg@pretzelnet.org:- * build.conf (infopages): remove reference to svn_for_cvs_users.++Patch by: epg@pretzelnet.org
>>> e-mail with no name
+++ NEW/r307 2005-07-16 12:43:24.000000000 -0500@@ -1,59 +1,59 @@ Allow for locally installed neon and apr. - * Makefile.in : Only build neon/ and apr subdirs if necessary. New+Patch by David Kimdon <David_Kimdon@alumni.hmc.edu>
>>> no colon
+++ NEW/r3306 2005-07-16 12:43:24.000000000 -0500@@ -1,5 +1,6 @@-Take Jeff Putsch <putsch@mxim.com>'s suggestion to add "--non-interactive"-option. With Mike Pilato:+With Mike Pilato, add "--non-interactive" option.++Suggested by: Jeff Putsch <putsch@mxim.com> >>> What did Mike Pilato do for this one? The original message does>>> not help. Is this C. Michael Pilato <cmpilato@collab.net>
+++ NEW/r3396 2005-07-16 12:43:24.000000000 -0500@@ -4,10 +4,10 @@ longer prints an underbar when the text is normal and props exhibit a change. All related tests are also updated and pass. -Thanks to Andreas J. Koenig <andreas.koenig@anima.de> and Rafael-Garcia-Suarez <raphel.garcia-suarez@hexaflux.com> for the initial-patches to main.c, status.c and cl.h.. -+Patch by: me+ Andreas J. Koenig <andreas.koenig@anima.de>+ Rafael Garcia-Suarez <raphel.garcia-suarez@hexaflux.com> +(They wrote the initial patches to main.c, status.c and cl.h.) >>> me is first
+++ NEW/r4059 2005-07-16 12:43:24.000000000 -0500@@ -1,5 +1,7 @@-fix issue 1027, patch provided by <rotering@animalcules.com>+Fix issue #1027. * subversion/clients/cmdline/util.c (svn_cl__get_log_message): initialize msg2 to NULL, avoiding a potential crash if svn_cl__edit_externally returns an error.++Patch by: <rotering@animalcules.com>
>>> If you decide not to put the other lone e-mails in <> then this>>> should be changed to match
--- OLD/r4209 2005-07-16 12:43:24.000000000 -0500+++ NEW/r4209 2005-07-16 12:43:24.000000000 -0500@@ -1,8 +1,8 @@ Revert revision 4181, and add two regression tests: one for the bug fixed by reverting, and one for the bug unfixed :-). -Thanks to Andreas Koenig <andreas.koenig@anima.de> for isolating this-problem and providing the test case.+Contribution by: Andreas Koenig <andreas.koenig@anima.de>+(Isolated the problem, provided the test case.) >>> Suggested by:
+++ NEW/r4337 2005-07-16 12:43:24.000000000 -0500@@ -1,6 +1,8 @@ Optionally deliver the output via SMTP to a host. -Based on a sample patch from Matt Kraai <kraai@alumni.cmu.edu>+Patch by: Greg Stein <gstein@collab.net>+ Matt Kraai <kraai@alumni.cmu.edu>+(This patch was based on Matt Kraai's original.) >>> If Greg Stein made this commit shouldn't it be>>> Patch by: Matt Kraai <kraai@alumni.cmu.edu>>>> me
+++ NEW/r4760 2005-07-16 12:43:24.000000000 -0500@@ -1,5 +1,7 @@-Const cleanup from julianfoad@btopenworld.com (except the editor.c-change, which I tacked on).+Const cleanups.++Patch by: julianfoad@btopenworld.com+(I tacked on the editor.c change.) >>> e-mail not in <>>>> (editor.c change by me.)
+++ NEW/r5166 2005-07-16 12:43:24.000000000 -0500@@ -1,4 +1,5 @@-Patch (concept) from Marko Macek <Marko.Macek@gmx.net>+Suggested by: Marko Macek <Marko.Macek@gmx.net>+(Patch concept by Marko.)
>>> concept comment may be redundant, Does suggested by cover that?
+++ NEW/r5426 2005-07-16 12:43:24.000000000 -0500@@ -1,7 +1,8 @@ Make mod_dav_svn leak a little less. -Based on Robert Pluim <rpluim@bigfoot.com>'s issue #1179 patch,-incorporating feedback from Greg Stein, and a few filigrees of my own.+Patch by: Robert Pluim <rpluim@bigfoot.com>+(From issue #1179.)+(Tweaked by Greg Stein <gstein@collab.net> and me.) >>> Impressive use of filigrees in normal sentence, consitency does remove>>> the flourishes.
+++ NEW/r5976 2005-07-16 12:43:24.000000000 -0500@@ -1,3 +1,5 @@ * subversion/svndumpfilter/main.c- (dump_opt_state): Fix copy-n-pasto. Report and fix by "P.Marek"- <pmarek@users.sourceforge.net>+ (dump_opt_state): Fix copy-n-pasto. ++Patch by: P.Marek <pmarek@users.sourceforge.net>+(Original report also by P.Marek.)
>>> copy-and-paste?
+++ NEW/r6010 2005-07-16 12:43:24.000000000 -0500@@ -1,8 +1,9 @@ Make the SWIG bindings to python as easy to use and as Python-esque as-possible by letting SWIG generate the shadow classes. Patch by-Philipp von Weitershausen <philipp@weitershausen.de> (the result of-previous discussion with cmpilato and gstein). Additional changes by-cmpilato.+possible by letting SWIG generate the shadow classes. ++Patch by: Philipp von Weitershausen <philipp@weitershausen.de> +(Resulting from previous discussion with cmpilato and gstein).+(Tweaked by me.) >>> Suggested by rather than Resulting ... ?
+++ NEW/r6515 2005-07-16 12:43:24.000000000 -0500@@ -2,7 +2,8 @@ packages/rpm/redhat-8+/subversion.spec, packages/rpm/redhat-8+/filter-requires.sh : PORTING file no longer exists. - Thanks to Ralph Loader <suckfish@ihug.co.nz> for the following changes:+The following changes only are from Ralph Loader.+Patch by: Ralph Loader <suckfish@ihug.co.nz> - Get rid of extraneous perl module dependencies via filter-requires.sh script for RedHat 8+.
>>> Possible put the following changes comment in ()'s after Patch line>>> consistent with previous entries with (above changes only)
--- OLD/r7579 2005-07-16 12:43:24.000000000 -0500+++ NEW/r7579 2005-07-16 12:43:24.000000000 -0500@@ -4,7 +4,7 @@ and, unlike functions, global variables can't be transparently imported from Windows DLLs in C. -Greg Stein <gstein@lyra.org> approved this commit.+Approved by: Greg Stein <gstein@lyra.org> >>> approved by -> username only
+++ NEW/r7605 2005-07-16 12:43:24.000000000 -0500@@ -1,6 +1,8 @@ Cleanup step to start issue 897 (error messages could be better).-Submitted by Erik Huelsmann <e.huelsmann@gmx.net>, based on ideas from-Files <files@poetryunlimited.com> and Brane <brane@xbc.nu>.++Patch by: Erik Hülsmann <e.huelsmann@gmx.net>+(Based on ideas from Files <files@poetryunlimited.com> and+Branko Čibej <brane@xbc.nu>.) >>> Suggested by: for the ideas people
+++ NEW/r7823 2005-07-16 12:43:24.000000000 -0500@@ -2,6 +2,9 @@ * perl/Core.pm (SVN::Stream): A better implementation of readline that uses $/ and respect the- returned eof state. Submitted by Plasma <plasmaball@pchome.com.tw>.+ returned eof state. -* INSTAL: Note that we require 5.8.0.+Patch by: Plasma <plasmaball@pchome.com.tw>+(Above change only.)+>>> plasma is lower case in all other cases
+++ NEW/r7878 2005-07-16 12:43:24.000000000 -0500@@ -1,6 +1,7 @@ Fix the perl bindings build on Mac OS X. -Parts of this patch suggested and/or contributed by Ben Reser <ben@reser.org>.+Patch by: me+ Ben Reser <ben@reser.org>. >>> me first
+++ NEW/r8033 2005-07-16 12:43:24.000000000 -0500@@ -5,4 +5,4 @@ for former "Bootstrapping from a Zip File under Windows" section. Add download URL and mention the self-extracting *-setup.exe. -Thanks to olczyk@interaccess.com for pointing out the need.+Suggested by: olczyk@interaccess.com
>>> e-mail not in <>
+++ NEW/r9203 2005-07-16 12:43:24.000000000 -0500@@ -1,6 +1,6 @@ Fix issue 1751, non-recursive switch updates all files in a directory. -Patch from <makl@tigris.org>+Patch by: <makl@tigris.org> >>> e-mail in <> fix if choose to not use
+++ NEW/r9315 2005-07-16 12:43:24.000000000 -0500@@ -2,8 +2,9 @@ were using C types where they should have been using svn or apr types. Helps with portability and fixes a problem on Windows. -Based on patches from Patrick Mayweg <mayweg@qint.de> and-Michael S. Liebman <m-liebman@northwestern.edu>+Contribution by: Patrick Mayweg <mayweg@qint.de>+ Michael S. Liebman <m-liebman@northwestern.edu>+(Based on their patches.) >>> Suggested by:
Received on Mon Jul 18 15:32:33 2005

This is an archived mail posted to the Subversion Dev mailing list.