[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn st -u regression with 1.1.x servers

From: Ben Collins-Sussman <sussman_at_collab.net>
Date: 2005-07-16 18:15:32 CEST

On Jul 16, 2005, at 6:40 AM, SteveKing wrote:
>
> subversion/libsvn_client/status.c: line 149
> if (err && err->apr_err == SVN_ERR_RA_NOT_IMPLEMENTED)
>
> now, SVN_ERR_RA_NOT_IMPLEMENTED defines to 170003, but err is
> 170002 when the status is fetched remotely from an 1.1.x server. So
> something is wrong here.

Oh my, how embarrassing. I can reproduce by running 'svn st -u'
against any svn repository on tigris.org (which is running svn 1.1).

svn 1.2 is running svn_ra_get_locks() during 'svn st -u'.
mod_dav_svn is throws SVN_ERR_UNSUPPORTED_FEATURE when it receives
the unfamiliar REPORT request (rather than RA_NOT_IMPLEMENTED, which
is what svnserve returns.) Does the following patch work for you?
It does for me.

I think this bug alone might justify an svn 1.2.2 release.

Index: subversion/libsvn_client/status.c
===================================================================
--- subversion/libsvn_client/status.c (revision 15350)
+++ subversion/libsvn_client/status.c (working copy)
@@ -147,7 +147,8 @@
       server doesn't support lock discovery, we'll just not do locky
       stuff. */
    err = svn_ra_get_locks (ras, &locks, "", rb->pool);
- if (err && err->apr_err == SVN_ERR_RA_NOT_IMPLEMENTED)
+ if (err && ((err->apr_err == SVN_ERR_RA_NOT_IMPLEMENTED)
+ || (err->apr_err == SVN_ERR_UNSUPPORTED_FEATURE)))
      {
        svn_error_clear (err);
        err = SVN_NO_ERROR;

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Jul 16 18:16:17 2005

This is an archived mail posted to the Subversion Dev mailing list.