[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] extract NLS initialization code form svn_cmdline_init

From: Garrett Rooney <rooneg_at_electricjellyfish.net>
Date: 2005-07-14 16:37:19 CEST

Kouhei Sutou wrote:
> Hi,
>
> In <42D322F9.1030604@electricjellyfish.net>
> "Re: [PATCH] extract NLS initialization code form svn_cmdline_init" on Mon, 11 Jul 2005 18:55:05 -0700,
> Garrett Rooney <rooneg@electricjellyfish.net> wrote:
>
>
>>>{{{
>>>Extract NLS initialization code from svn_cmdline_init.
>>>
>>>* subversion/libsvn_subr/nls.c
>>> (svn_nls_environment_init): Initialize NLS environment.
>>> (svn_nls_init): Initialize NLS environment and set up
>>> text domain.
>>>
>>>* subversion/include/svn_nls.h: Add.
>>>
>>>* subversion/libsvn_subr/cmdline.c
>>> (svn_cmdline_init): Extract NLS initialization code.
>>>}}}
>>>
>>>
>>>By the way, I have an anxiety. The codes are *not* tested on
>>>WIN32 environment because I don't have the
>>>environment. Could someone test the codes on WIN32
>>>environment?
>>
>>+1, although I would also like to see someone test this on win32 if
>>possible, although if you don't get a reply from anyone within the next
>>day or two I'd say just commit it, it's just moving existing code
>>around, and in the unlikely event that it breaks something I imagine
>>we'll know reasonably quickly.
>
>
> I waited two days but there are no response. Can I commit
> this?

That seems fine to me, +1.

-garrett

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Jul 14 16:39:05 2005

This is an archived mail posted to the Subversion Dev mailing list.