[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Verbose error messages for invalid dates

From: Christopher Ness <chris_at_nesser.org>
Date: 2005-07-08 05:27:14 CEST

Hi!

As I'm going over my date patch again I'd like to add some more
verbosity to the error messages for poorly formatted dates used for
revisions.

The goal is to inform the user that their revision -r{05-01-01} failed
because it does not meet subversion's date format[s] instead of the
vague string of:
             Syntax error in revision argument '{0-0-0}'

What is the [best] way to pass an error from svn_opt_parse_revision() up
to (subversion/clients/cmdline/main.c) main() ?

I think the problem - from my understanding at least - is in
svn_opt_parse_revision() and parse_one_rev().

In parse_one_rev() any error info that is returned back is whipped out.

   err = svn_parse_date (&matched, &tm, str, apr_time_now (), pool);
   if (err)
     {
       svn_error_clear (err);
       return NULL;
     }

How do I break out the information from the lower level to the user?

Cheers,
Chris

-- 
PGP Public Key: http://www.nesser.org/pgp-key/
22:18:43 up 3:37, 5 users, load average: 0.55, 1.24, 0.87

Received on Fri Jul 8 05:26:58 2005

This is an archived mail posted to the Subversion Dev mailing list.