[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

[PATCH] issue #2304: default to configured mime-type - v1

From: Hyrum K. Wright <hyrum_wright_at_byu.edu>
Date: 2005-07-07 17:45:41 CEST

This patch fixes issue 2304. (From the issue tracker:) In
mod_dav_svn/liveprop.c, we default to setting a file's mime-type to
"text/plain" if nothing else is known about the file. Brane suggested
using httpd.conf's DefaultType directive before resorting to "text/plain".

This patch calls the ap_default_type function in place of setting the
mime-type. This function returns the value of the DefaultType, or
"text/plain" if it is not configured.

I have not yet tested this patch, as I am having trouble figuring out
how. If anybody could tell me what the best way to test it would be,
that would be great.


Fix issue #2304 by calling apache's ap_default_type method to get the
server's default mime-type when nothing is known about the file. We
don't need another else clause because ap_default_type will return
"text/plain" if the DefaultType is not set in httpd.conf.

* subversion/mod_dav_svn/liveprops.c
  Include http_core.h.
  (dav_svn_insert_prop): Replaced default assignment to "text/plain"
  with a call to ap_default_type.

Received on Thu Jul 7 17:47:03 2005

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.