[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] new feature: takeover

From: Philip Martin <philip_at_codematters.co.uk>
Date: 2005-07-06 01:14:50 CEST

"Jonathan Gilbert" <o2w9gs702@sneakemail.com> writes:

> When I added the command to the front-end of the command-line client, I
> created an accompanying 'help' page. I preserved the same options that 'svn
> checkout' takes, because my new 'svn takeover' is identical in behaviour to
> 'svn checkout', with the exception of leaving existing files alone (and not
> considering them a fatal error).

It helps us review the patch if you write a log message, see the
HACKING file.

I think this is a feature a lot of people have been requesting, but
I'm wondering why you made it a new command and not just a checkout
(and update?) option?

> Up until the code interfaces with the edit script driver & update editor,
> the boolean indicating that a takeover is in progress is passed as an
> additional parameter to functions (where applicable, I created a new
> function, leaving the old interface intact with the old non-takeover
> behaviour). Since the actual checking out of files during 'svn checkout' is
> done by means of an update, after creating a skeleton .svn directory, the
> flag gets passed there too. Once the code creates the svn_delta_editor_t
> instance, it ceases to be a parameter; it is instead stored within the
> struct. It is pulled back out of the struct and turned into a parameter
> again only right before the add_file vtable entry is called, since add_file
> does not receive a reference, direct or otherwise, to the editor.
>
> If I've missed any salient points, let me know, and I'll explain any other
> changes I've made :-)

Bad news :( I've had a very brief look at the patch and it looks like
you have modified the ABI. The changes to svn_delta_editor_t and
svn_wc_notify_action_t will break binary compatibility, again see the
HACKING file, which means that the patch is not suitable for
Subversion 1.x.

-- 
Philip Martin
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Jul 6 01:46:59 2005

This is an archived mail posted to the Subversion Dev mailing list.