[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH]: issue #2264 - multiple locks over ra_svn - v4

From: Julian Foad <julianfoad_at_btopenworld.com>
Date: 2005-07-05 22:07:07 CEST

kfogel@collab.net wrote:
> VK Sameer <sameer@collab.net> writes:
>>Index: subversion/libsvn_ra_svn/client.c
>>===================================================================
>>--- subversion/libsvn_ra_svn/client.c (revision 15189)
>>+++ subversion/libsvn_ra_svn/client.c (working copy)
[...]
>>+ err = handle_auth_request(sess, pool);
>>+
>>+ /* Pre-1.3 servers don't support 'lock-many'. If that fails, fall back
>>+ * to 'lock'. */
>>+ if (err && err->apr_err == SVN_ERR_RA_SVN_UNKNOWN_CMD &&
>>+ strcmp (err->message, "Unknown command 'lock-many'") == 0)
>>+ return ra_svn_lock_compat(session, path_revs, comment, force, lock_func,
>>+ lock_baton, pool);

(I'm chipping in with no knowledge again.) Is it really necessary and
appropriate to do a string comparison of the error message text? It appears to
me that just testing the error code would be sufficient.

- Julian

> The documentation for 'svn_error_t' doesn't make it clear whether
> err->message can ever be NULL. Our code seems to be inconsistent on
> this point. This is not a problem with your patch, it's just
> something we ought to raise separately on the dev@ list. I'll bring
> it up.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Jul 5 22:10:51 2005

This is an archived mail posted to the Subversion Dev mailing list.