[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] issue#2317 - Problem with Peg Revisions for filescontaining '@'

From: Alexander Thomas <alexander_at_collab.net>
Date: 2005-07-04 13:50:54 CEST

Thanks for the review :)
On Mon, 2005-07-04 at 12:24 +0100, Max Bowsher wrote:
> I really don't like this particular bit.
>
> First, don't put anything in a public header unless there is a good reason
> for it to be public. I don't see any reason for these to be.
 I don't have a very good reason to state, why we need it. :)
 New version of the patch attached

[[[
Version 2: Fix for issue 2317 - Problem with Peg Revisions for files
containing '@'.

* subversion/libsvn_subr/opt.c
  (svn_opt_parse_path): Modified.

* subversion/tests/clients/cmdline/basic_tests.py
  (basic_peg_revision): New test.
  (test_list): Added basic_peg_revision to list.
]]]

Version 2: Fix for issue 2317 - Problem with Peg Revisions for files containing '@'.

* subversion/libsvn_subr/opt.c
  (svn_opt_parse_path): Modified.

* subversion/tests/clients/cmdline/basic_tests.py
  (basic_peg_revision): New test.
  (test_list): Added basic_peg_revision to list.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Received on Mon Jul 4 14:24:25 2005

This is an archived mail posted to the Subversion Dev mailing list.