[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] issue#2317 - Problem with Peg Revisions for filescontaining '@'

From: Max Bowsher <maxb_at_ukf.net>
Date: 2005-07-04 13:24:14 CEST

Alexander Thomas wrote:
>> Index: subversion/include/svn_types.h
>> ===================================================================
>> --- subversion/include/svn_types.h (revision 15206)
>> +++ subversion/include/svn_types.h (working copy)
>> @@ -283,6 +283,19 @@
>> /** A compressed combination of the other four keywords. */
>> #define SVN_KEYWORD_ID "Id"
>>
>> +/** Special revision descriptors HEAD */
>> +#define SVN_KEYWORD_REVISION_HEAD "head"
>> +
>> +/** Special revision descriptors BASE */
>> +#define SVN_KEYWORD_REVISION_BASE "base"
>> +
>> +/** Special revision descriptors PREV */
>> +#define SVN_KEYWORD_REVISION_PREV "prev"
>> +
>> +/** Special revision descriptors COMMITTED */
>> +#define SVN_KEYWORD_REVISION_COMMIT "committed"

I really don't like this particular bit.

First, don't put anything in a public header unless there is a good reason
for it to be public. I don't see any reason for these to be.

Second, since SVN_KEYWORD_* seems to have become associated with sustitution
keywords, please can we pick a thoughroughly distinct prefix for revision
keywords.

SVN_REVKW_* perhaps?

Max.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Jul 4 13:27:43 2005

This is an archived mail posted to the Subversion Dev mailing list.