[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Move authz access control to libsvn_repos

From: David Anderson <david.anderson_at_calixo.net>
Date: 2005-07-03 05:10:40 CEST

Greg Hudson wrote:
> Add entries for the two new functions, explaining that you factored out
> logic previously duplicated in authz_parse_section and
> authz_get_path_access.

Done in the commit message at end of mail.

> The documentation you wrote for svn_repos_authz_check_access does not
> document that path can be NULL. Presumably this relates to some part of
> the contract with httpd, so the logic should remain in mod_authz_svn.

Indeed. Moved test+comment back to mod_authz_svn and documented the
test's function.

Here goes... :-)

- Dave.

[[[
Move authz routines from mod_authz_svn to libsvn_repos; rework authz
code to fit in with libsvn_repos; update mod_authz_svn to reflect
the move.

* subversion/mod_authz_svn/mod_authz_svn.c: Add includes, remove
     nameless enum. Update copyright notice.
   (parse_authz_baton, group_contains_user_internal,
    group_contains_user, parse_authz_line,
    parse_authz_lines, parse_authz_section,
    parse_authz_sections, check_access): Remove, functionality
     moves to libsvn_repos.
   (req_check_access): Use the authz routines in libsvn_repos and wrap
     any errors reported by the authz layer. Test for a NULL repos_path
     here rather than in check_access.

* subversion/include/svn_repos.h: Add include. Update copyright notice.
   (svn_authz_access_kind_t): New enum type.
   (svn_repos_authz_check_access): New public API.

* subversion/libsvn_repos/authz.c: New file. Contains the functionality
     moved from mod_authz_svn. Rename functions and variable names to
     better fit libsvn_repos. Add internal API and in-function
     documentation.
   (authz_access_is_granted, authz_access_is_determined): New functions
     that refactor and document obfuscated tests that were previously in
     authz_parse_section and authz_get_path_access.

* subversion/tests/libsvn_repos/repos-test.c: Add includes. Update
     copyright notice.
   (authz): New test.
]]]

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Received on Sun Jul 3 05:11:59 2005

This is an archived mail posted to the Subversion Dev mailing list.