Re: [PATCH] Move authz access control to libsvn_repos

On Sun, 2005-07-03 at 03:36 +0200, David Anderson wrote:
> Moved. When should types be defined in svn_types.h ?

Generally, when there isn't an obvious better place to put them. But it
doesn't look like we're 100% consistent here; for instance, svn_error_t
could be defined in <svn_error.h> and it isn't.

> Aside from the "cosmetic"
> changes, the two macros are the only logical change I can recall.
[...]
> How can I explain all this in the commit message?

Add entries for the two new functions, explaining that you factored out
logic previously duplicated in authz_parse_section and
authz_get_path_access.

I also found this:

+ if (!path) {
+ /* XXX: Check if the user has 'required_access' _anywhere_ in the
+ * XXX: repository. For now, make this always succeed, until
+ * XXX: we come up with a good way of figuring this out.
+ */

The documentation you wrote for svn_repos_authz_check_access does not
document that path can be NULL. Presumably this relates to some part of
the contract with httpd, so the logic should remain in mod_authz_svn.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sun Jul 3 04:03:56 2005