[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Should authz return errors? (Was: Re: SoC: Path-based authz for Svnserve)

From: <kfogel_at_collab.net>
Date: 2005-07-01 20:08:13 CEST

Greg Hudson <ghudson@MIT.EDU> writes:
> On Fri, 2005-07-01 at 14:13 +0200, David Anderson wrote:
> > So, this all comes down to: should the authz API return errors when it
> > discovers a malformed ACL configuration?
>
> While it's probably best to have an svn_error_t * return for the
> relevant functions, I think in practice, errors should be returned when
> the authz file is read, not when authz queries are made.
>
> That means the reading code has to go to a substantial amount of extra
> work validating everything, but:
>
> * This way you'll notice immediately if you screw up your authz file,
> instead of only noticing when you try to check out or commit to some
> obscure part of your repository.
>
> * This way will produce much more graceful failure than conking out in
> the middle of an update/commit.

That's what I thought I meant, sorry if my response didn't make that
clear.

David, try to break things down into little, separate patches, please.
For example, making the authz-config-file-reading detect errorful
situations should be its own patch. (You may have known this already,
I wasn't sure when you said "It'll be corrected in my first patch
then" if you meant that your first patch would be this change, or
would include this change. The former is desirable.)

-K

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Jul 1 21:15:47 2005

This is an archived mail posted to the Subversion Dev mailing list.