[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Should authz return errors? (Was: Re: SoC: Path-based authz for Svnserve)

From: Greg Hudson <ghudson_at_MIT.EDU>
Date: 2005-07-01 18:55:21 CEST

On Fri, 2005-07-01 at 14:13 +0200, David Anderson wrote:
> So, this all comes down to: should the authz API return errors when it
> discovers a malformed ACL configuration?

While it's probably best to have an svn_error_t * return for the
relevant functions, I think in practice, errors should be returned when
the authz file is read, not when authz queries are made.

That means the reading code has to go to a substantial amount of extra
work validating everything, but:

  * This way you'll notice immediately if you screw up your authz file,
instead of only noticing when you try to check out or commit to some
obscure part of your repository.

  * This way will produce much more graceful failure than conking out in
the middle of an update/commit.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Jul 1 19:10:15 2005

This is an archived mail posted to the Subversion Dev mailing list.