[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Should authz return errors? (Was: Re: SoC: Path-based authz for Svnserve)

From: David Anderson <david.anderson_at_calixo.net>
Date: 2005-07-01 17:52:41 CEST

kfogel@collab.net wrote:
> Well, unless there's some larger issue here I'm missing, this just
> sounds like a bug. Both circumstances should be detected, and return
> errors -- and, I mean, returning 'svn_error_t *' is the norm in our
> interfaces, so can it really be that much more cumbersome?

It's more cumbersome than the interface currently defined in
mod_authz_svn, which attempts to gracefully ignore the problems and
therefore doesn't need to handle errors in the authz parsing code.
That's what I meant by "more cumbersome" : svn_error_t's need to be
added to the interface. I didn't mean that I object to handling the
errors :)

So, a bug it is. It'll be corrected in my first patch then :-)

- Dave.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Jul 1 18:06:51 2005

This is an archived mail posted to the Subversion Dev mailing list.