[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [Patch] Issue #2291 - 'svn ls -v' return locking information

From: Ben Collins-Sussman <sussman_at_collab.net>
Date: 2005-07-01 15:26:17 CEST

On Jul 1, 2005, at 6:25 AM, Alexander Thomas wrote:

> Yes I agree, initially I done the same. Because svn_lock_t is
> declared
> below the new structure, we are force to use 'struct svn_lock_t*' not
> the typedef name 'svn_lock_t*'. Will I violating any svn community
> rules
> for not using typedef ? :)

How about just rearranging the structure definitions in the header
file? :-)

>
> Currently I am using only 2 out of 5 new structure elements
> (lock_owner
> & lock_creation_date), What U think of removing unused elements ?
> because some elements from svn_info_t will also peak in later, as the
> issue says

When somebody calls svn_client_ls(), why not give them access to all
the lock fields? Just because you're not printing all the fields
doesn't mean we should artifically restrict the API. Other clients
(other than our commandline client) might use more information.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Jul 1 15:29:26 2005

This is an archived mail posted to the Subversion Dev mailing list.