[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [Patch] Issue #2291 - 'svn ls -v' return locking information

From: Alexander Thomas <alexander_at_collab.net>
Date: 2005-07-01 13:25:06 CEST

On Thu, 2005-06-30 at 10:22 -0500, Ben Collins-Sussman wrote:
> On Jun 30, 2005, at 5:41 AM, Alexander Thomas wrote:
>
> >
> > +typedef struct svn_dirent2_t
> > +{
> > + /** node kind */
> > + svn_node_kind_t kind;
> >
> > + /** length of file text, or 0 for directories */
> > + svn_filesize_t size;
> > +
> > + /** does the node have props? */
> > + svn_boolean_t has_props;
> > +
> > + /** last rev in which this node changed */
> > + svn_revnum_t created_rev;
> > +
> > + /** time of created_rev (mod-time) */
> > + apr_time_t time;
> > +
> > + /** author of created_rev */
> > + const char *last_author;
> > +
> > + /** lock token or NULL if path not locked in this REPOS */
> > + const char *lock_token;
> > +
> > + /** lock owner, or NULL if not locked in this REPOS */
> > + const char *lock_owner;
> > +
> > + /** lock comment or NULL if not locked in this REPOS or no
> > comment */
> > + const char *lock_comment;
> > +
> > + /** Lock creation date or 0 if not locked in this REPOS */
> > + apr_time_t lock_creation_date;
> > +
> > + /** Lock expiration date or 0 if not locked in this REPOS */
> > + apr_time_t lock_expiration_date;
> > +
> > +} svn_dirent2_t;
> > +
>
>
> OK, so here's my one big piece of feedback: you added 5 new fields
> to the svn_dirent_t structure above. You could have simply added
> one: an svn_lock_t. Wouldn't that be much simpler? If the
> svn_lock_t field is NULL, there's no repository lock on the object.
> If it's non-NULL, then all the fields of the lock_t are filled in.
>
  Yes I agree, initially I done the same. Because svn_lock_t is declared
below the new structure, we are force to use 'struct svn_lock_t*' not
the typedef name 'svn_lock_t*'. Will I violating any svn community rules
for not using typedef ? :)
  
 Currently I am using only 2 out of 5 new structure elements (lock_owner
& lock_creation_date), What U think of removing unused elements ?
because some elements from svn_info_t will also peak in later, as the
issue says

Thanks
-Alexander Thomas (AT)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Jul 1 13:56:01 2005

This is an archived mail posted to the Subversion Dev mailing list.