[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Auth data not saved when locking files

From: Daniel Rall <dlr_at_finemaltcoding.com>
Date: 2005-06-17 00:11:31 CEST

On Thu, 2005-06-16 at 15:23 -0500, kfogel@collab.net wrote:
>SteveKing <steveking@gmx.ch> writes:
>> > SteveKing <steveking@gmx.ch> writes:
>> >
>> >>A TSVN user reported that the authentication wasn't stored when he was
>> >>locking files. Since I couldn't find a reason for this in the code, I
>> >>tried the CL client, and the CL client doesn't store the auth info
>> >>either.
>> >>
>> >>Steps to reproduce:
>> >>
>> >>- have a wc checked out from a http server (haven't checked other
>> >>server types)
>> >>- make sure you have to authenticate (otherwise it won't make any sense)
>> >>- also check the config file that 'store-auth-creds' is commented
>> > ^^^^^^^^^
>> > "commented" or "uncommented"? Can you just show us the exact contents
>> > of the file?
>>
>> I mean commented out, i.e. not set to 'yes'. If it was set, then it
>> wouldn't be a bug that Subversion doesn't store the auth data ;)
>> My config file is unchanged, i.e. like if you delete it and the CL
>> client creates it again.
>>
>> >>- go to the wc
>> >>- do an 'svn lock filename'
>> >>- enter the auth data (username/password)
>> >>- do again an 'svn lock filename'
>> >>- Subversion asks for the auth data again.
>
>Okay, this sounds like a bug, then -- thanks. Want to file?

Are we perhaps not calling svn_ra_dav__maybe_store_auth_info somewhere
in libsvn_ra_dav where we should be?

commit.c:1479: SVN_ERR( svn_ra_dav__maybe_store_auth_info(cc->ras) );
fetch.c:1087: SVN_ERR( svn_ra_dav__maybe_store_auth_info(ras) );
fetch.c:2890: SVN_ERR( svn_ra_dav__maybe_store_auth_info (rb->ras) );
util.c:885:svn_ra_dav__maybe_store_auth_info(svn_ra_dav__session_t *ras)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Jun 17 00:13:24 2005

This is an archived mail posted to the Subversion Dev mailing list.