[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: BUG(?): "svn diff" behaves incorrectly on symbolic links pointing to binary files

From: <kfogel_at_collab.net>
Date: 2005-06-16 15:43:21 CEST

"Wesley J. Landaker" <wjl@icecavern.net> writes:
> Okay, well Vincent was the original reporter for this bug on the Debian
> side, and it sounds like what he was seeing is fixed, so I'll go ahead and
> close this bug (both in Debian, and in the Subversion issue tracker).

Yup. Thanks for handling the bookkeeping (and your guess was right,
I'd forgotten that you were not the original reporter, thanks for
clarifying).

> My gut feel is that since svn diff in all other cases goes out of it's way
> not to print binary data to the screen, it should not in this case either,
> even if it's technically the user's own fault. But, I don't feel super
> strongly about it, since the reproduction recipe(s) for this are use cases
> that I personally would probably not encounter very often.
>
> Anyway, as far as if this behavior is correct or if it should be fixed, I'll
> let you guys work it out for now, as I will be out of town for the next
> week and a half (so I won't be able to follow this thread with much vigor).

Well, what constitutes screen-unfriendly binary data depends on the
locale. I'm not against Subversion behaving better here, if we can
define what "better" means. But in any case, it's a different issue
than the ones originally opened, so those should be closed no matter
what. We may open a new one, if we decide to make this other change.

-Karl

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Jun 16 16:28:10 2005

This is an archived mail posted to the Subversion Dev mailing list.