[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: BUG(?): "svn diff" behaves incorrectly on symbolic links pointing to binary files

From: Wesley J. Landaker <wjl_at_icecavern.net>
Date: 2005-06-16 01:21:35 CEST

Consolidating a few messages in this reply:

On Wednesday 15 June 2005 05:25, Vincent Lefevre wrote:
> On 2005-06-14 12:51:12 -0500, kfogel@collab.net wrote:
> > Well -- hmmm, and that would seem to be the recipe implied in the
> > original report, too. Vincent? Can you reproduce this bug with
> > Subversion 1.2 or with head of trunk?
> With Subversion 1.2 (latest Debian package), I confirm that the
> behavior is correct:

Okay, well Vincent was the original reporter for this bug on the Debian
side, and it sounds like what he was seeing is fixed, so I'll go ahead and
close this bug (both in Debian, and in the Subversion issue tracker).

On Tuesday 14 June 2005 21:42, kfogel@collab.net wrote:
> Oh.
> This behavior has nothing to do with symlinks. If you 'svn add' a
> text file, then replace its contents with binary data, Subversion
> never finds out that it changed from text to binary, and will happily
> diff it (unhappily for the user, of course).
> A reproduction recipe that involves no symlinks:

On Wednesday 15 June 2005 05:45, Vincent Lefevre wrote:
> Concerning this point, I think this is a bug (but a different one):
> if in the diff, there are non-printable characters, then they should
> be filtered out when the output is a tty. Otherwise this can mess up
> the terminal. (I'm not sure whether this problem is unix-specific or
> more general...)

My gut feel is that since svn diff in all other cases goes out of it's way
not to print binary data to the screen, it should not in this case either,
even if it's technically the user's own fault. But, I don't feel super
strongly about it, since the reproduction recipe(s) for this are use cases
that I personally would probably not encounter very often.

Anyway, as far as if this behavior is correct or if it should be fixed, I'll
let you guys work it out for now, as I will be out of town for the next
week and a half (so I won't be able to follow this thread with much vigor).

Wesley J. Landaker <wjl@icecavern.net>
OpenPGP FP: 4135 2A3B 4726 ACC5 9094  0097 F0A9 8A4C 4CD6 E3D2

  • application/pgp-signature attachment: stored
Received on Thu Jun 16 01:22:33 2005

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.