[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Automated emails to svn-breakage for Ruby bindings (v2)

From: Kouhei Sutou <kou_at_cozmixng.org>
Date: 2005-06-09 18:05:18 CEST

Hi,

In <df2177af05060908402ed45194@mail.gmail.com>
  "Re: [PATCH] Automated emails to svn-breakage for Ruby bindings (v2)" on Thu, 9 Jun 2005 11:40:13 -0400,
  David James <james82@gmail.com> wrote:

> > Sorry, I can't make judgements whether the patch is good or
> > not.
> > # I think the following diff is not necessary.
> > # - cd $(SWIG_RB_DIR); $(RUBY) test/run-test.rb
> > # + cd $(SWIG_RB_DIR); $(RUBY) $(SWIG_RB_TEST_SRCDIR)/run-test.rb
>
> The above patch makes a difference when $(abs_builddir) is not the
> same as $(abs_srcdir). In your original code, you look in
> $(SWIG_RB_DIR)/test for the run-test.rb file. Since
> SWIG_RB_DIR=$(abs_builddir)/subversion/bindings/swig/ruby, this means
> that you are looking in the build directory for the "run-test.rb"
> file. If the build directory is the same as the source directory, then
> this will work.
>
> On the other hand, if the build directory is different from the source
> directory, then run-test.rb will not exist inside
> $(abs_builddir)/subversion/bindings/swig/ruby. So, my patch switches
> the Makefile to look in $(abs_srcdir)/subversion/bindings/swig/ruby
> instead.

I see.

Then I want to do the following.

+SWIG_RB_SRCDIR = $(abs_srcdir)/subversion/bindings/swig/ruby

- cd $(SWIG_RB_DIR); $(RUBY) test/run-test.rb
+ cd $(SWIG_RB_SRCDIR); $(RUBY) test/run-test.rb

--
kou
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Jun 9 18:07:21 2005

This is an archived mail posted to the Subversion Dev mailing list.