[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Automated emails to svn-breakage for Ruby bindings (v2)

From: Kouhei Sutou <kou_at_cozmixng.org>
Date: 2005-06-09 18:04:47 CEST

Hi,

# I want David to remove Replay-To header.

In <df2177af050608101278848894@mail.gmail.com>
  "Re: [PATCH] Automated emails to svn-breakage for Ruby bindings (v2)" on Wed, 8 Jun 2005 13:12:14 -0400,
  David James <james82@gmail.com> wrote:

> > Currently the Ruby bindings do not pass tests ( see
> > http://svn.haxx.se/dev/archive-2005-06/0215.shtml ).
> >
> > * tools/test-scripts/svntest/svntest-bindings.sh:
> > (Ruby): Test the ruby compile, install, and test targets if
> > TEST_BINDINGS_SWIG_RUBY=yes
> >
> > * tools/test-scripts/svntest/svntest-config.sh:
> > (Ruby): Add in TEST_BINDINGS_SWIG_RUBY variable to allow users
> > to configure whether they want to run the Ruby tests.
> >
> > * Makefile.in:
> > (check-swig-rb): Switch check-swig-rb to look in the source dir
> > instead of the build dir for the test scripts, in case we are
> > running in a VPATH setup.
> Oops. Fixed a minor typo. Version 2 of the patch is attached.

Sorry, I can't make judgements whether the patch is good or
not.
# I think the following diff is not necessary.
# - cd $(SWIG_RB_DIR); $(RUBY) test/run-test.rb
# + cd $(SWIG_RB_DIR); $(RUBY) $(SWIG_RB_TEST_SRCDIR)/run-test.rb

Could you wait someone makes judgments the patch?

--
kou
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Jun 9 18:06:07 2005

This is an archived mail posted to the Subversion Dev mailing list.