[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] issue #2069 - "svn status" in xml mode - v6

From: Peter N. Lundblad <peter_at_famlundblad.se>
Date: 2005-06-02 10:03:38 CEST

On Thu, 2 Jun 2005, Julian Foad wrote:

> Some comments on the DTD.
>

I'm replying, since I wrote most of this DTD (without the comments:-).
> Alexander Thomas wrote:
> > Index: subversion/clients/cmdline/dtd/status.dtd
> > ===================================================================
> > --- subversion/clients/cmdline/dtd/status.dtd (revision 0)
> > +++ subversion/clients/cmdline/dtd/status.dtd (revision 0)
> > @@ -0,0 +1,47 @@
> > +<!-- XML DTD for Subversion command-line client output. -->
> > +
> > +<!-- For "svn status" -->
> > +<!ENTITY % BOOL '(true | false) "false"'>
>
> It doesn't seem appropriate to have a default value. You are always
> generating these attributes when they are applicable, aren't you?

Nope. Since copied and switches are normally uncommon, it seemed silly to
output them for every entry. So the default value makes sense.

>
> > +<!ATTLIST wc-status
> > + item (added | conflicted | deleted | merged | ignored | modified |
> > + replaced | external | unversioned | incomplete | obstructed |
> > + normal | none) #REQUIRED
>
> "merged" is not possible.

Correct. I remember it was recently removed from the help output, which I
partly used when modelling this DTD.

> I don't think "none" is possible either.
>
Maybe not. The status code is somewhat complicated, so you never know:-)
I'll see if I can figure this out. Else, I leave the "none" value to be
safe...

> > + props (conflicted | modified | normal | none) #REQUIRED
>
> I don't think "none" is possible.
>
Yes, when there are no props.

I'll take another look at the comments.

Thanks,
//Peter

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Jun 2 09:54:33 2005

This is an archived mail posted to the Subversion Dev mailing list.