[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] issue #2069 - "svn status" in xml mode - v6

From: Julian Foad <julianfoad_at_btopenworld.com>
Date: 2005-06-02 02:42:54 CEST

Some comments on the DTD.

Alexander Thomas wrote:
> Index: subversion/clients/cmdline/dtd/status.dtd
> ===================================================================
> --- subversion/clients/cmdline/dtd/status.dtd (revision 0)
> +++ subversion/clients/cmdline/dtd/status.dtd (revision 0)
> @@ -0,0 +1,47 @@
> +<!-- XML DTD for Subversion command-line client output. -->
> +
> +<!-- For "svn status" -->
> +<!ENTITY % BOOL '(true | false) "false"'>

It doesn't seem appropriate to have a default value. You are always generating
these attributes when they are applicable, aren't you?

> +<!ELEMENT status (target*)>
> +
> +<!ELEMENT target (entry*, against?)>
> +<!-- target path -->

<!-- path: target path -->

> +<!ATTLIST target
> + path CDATA #REQUIRED>
> +
> +<!ELEMENT entry (wc-status, repos-status?)>

<!-- path: entry path -->

> +<!ATTLIST entry
> + path CDATA #REQUIRED>
> +
> +<!ELEMENT wc-status (lock?)>
> +<!-- WC dir locked? -->
> +<!-- Add with history? -->
> +<!-- Item switched -->

This comment would be better:
<!-- item: the schedule status of the item -->
<!-- props: the schedule status of the item's properties -->
<!-- wc-locked: WC dir locked? -->
<!-- copied: add with history? -->
<!-- switched: item is switched relative to its parent? -->

> +<!ATTLIST wc-status
> + item (added | conflicted | deleted | merged | ignored | modified |
> + replaced | external | unversioned | incomplete | obstructed |
> + normal | none) #REQUIRED

"merged" is not possible.
I don't think "none" is possible either.

> + props (conflicted | modified | normal | none) #REQUIRED

I don't think "none" is possible.

> + wc-locked %BOOL;
> + copied %BOOL;
> + switched %BOOL;
> +>
> +
> +<!ELEMENT repos-status (lock?)>

Comment:
<!-- item: the repository status of the item -->
<!-- props: the repository status of the item's properties -->

> +<!ATTLIST repos-status
> + item (added | deleted | modified | replaced | none) #REQUIRED
> + props (modified | none) #REQUIRED
> +>
> +
> +<!-- Lock info stored in WC or repos. -->
> +<!ELEMENT lock (token, owner, comment?, created, expires?)>
> +
> +<!ELEMENT token (#PCDATA)> <!-- Lock token URI. -->
> +<!ELEMENT owner (#PCDATA)> <!-- Lock owner. -->
> +<!ELEMENT comment (#PCDATA)> <!-- Lock Comment. -->
> +<!ELEMENT created (#PCDATA)> <!-- Creation date in ISO format. -->
> +<!ELEMENT expires (#PCDATA)> <!-- Expiration date in ISO format. -->
> +
> +<!ELEMENT against EMPTY>

Comment:
<!-- against: the revision number at which the repository information was
obtained -->

> +<!ATTLIST against revision CDATA #REQUIRED>

- Julian

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Jun 2 02:43:41 2005

This is an archived mail posted to the Subversion Dev mailing list.