[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: RFC: Log Message Templates via new hook.

From: <kfogel_at_collab.net>
Date: 2005-05-27 19:49:41 CEST

SteveKing <steveking@gmx.ch> writes:
> But you have to remember that this crawling is much faster than a
> server connection.
>
> But I'll try to explain more clearly why I want this configured with a
> property (or something else stored locally):
>
> if no such property is available, then TSVN would have to either
> - always pass --no-file-list to the hook script if we allow the user
> to start typing the log message before the file list is known. This
> might anger admins which want their users to follow the template
> generated from the filelist.
> - always prevent the user from typing the log message until we
> contacted the repository. This definitely *will* get users angry which
> don't even use log message templates (I know that, because the feature
> of typing the log message before the file list is know was repeatedly
> requested, and I got some angry mails once this feature didn't work
> properly).
>
> So, whatever TSVN does without such a property, it will always make
> some people angry.

Did you not see my proposal for a third way, that would allow TSVN to
solve this without requiring any special properties? It's in:

http://subversion.tigris.org/servlets/ReadMsg?list=dev&msgNo=100709

By the way, a wc crawl would not be noticeably faster than a
no-files-list round trip to the server in most cases, I believe. One
network turnaround can happen quite quickly.

> both options won't make our users very happy. Especially if you think
> about the hook script won't be used by much repo admins (considering
> they have to update their server first), also many projects will be
> happy with static templates and don't need the magic hook script.

Are you sure? Consider the 'pre-revprop-change' hook. I think most
repositories set that up, so people can change commit messages, and
yet it is *not* enabled by default.

If users of a repository want log message templates, then the admin
will of course set up the script (and doing so will be very simple,
since we will have written a script that works for 90% of sites).

> So, I'd like to have the admin decide if TSVN (or other GUI clients)
> can allow the user to start typing the log message, if typing isn't
> allowed at all until the filelist is known, or if typing is allowed
> but the hook script still has to be used (with the --no-file-list
> option).

Again, the third-way solution solves this.

> Sure, if Subversion won't implement such a property (or whatever other
> means), then TSVN will have to define its own property for that (as we
> already do with a lot of other options, since Subversion still lacks
> server side configs passed to clients).
>
> But still, I think it would be better if Subversion would at least
> *define* such a property, so all GUI clients can use the same property
> (and it would be documented by Subversion, so really all clients know
> that such a property exists and not every client implements its own
> property).

Agreed. I think it would be fine for us to reserve a new "svn:foo"
property for TSVN (and other clients) to use, whether or not
Subversion itself does anything with that property.

-Karl

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri May 27 20:28:15 2005

This is an archived mail posted to the Subversion Dev mailing list.