[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Issue #443: post-commit hook script (error) output lost

From: Peter N. Lundblad <peter_at_famlundblad.se>
Date: 2005-05-20 14:50:26 CEST

On Fri, 20 May 2005, Madan US wrote:

> > this is not a complete review, just clafirying some of philip's points.
> >
> > On Tue, 10 May 2005, Philip Martin wrote:
> >
> >> "Madan US" <madan@collab.net> writes:
> >>
> [...]
> >>
> >> Hmm, a quick experiment shows that the existing hook output appears to
> >> get escaped over ra_dav, but not encoded. The hook needs to output
> >> UTF-8 if it is to be displayed by the client, otherwise I just see
> >> "svn: General svn error from server".
> >>
> > It definitely needs to be XML-escaped. Whether it should be recoded
> > from the locale encoding is another topic - and should be a separate
> > change IMO. Oh, and it needs base4 encoding as well, or filtering so
> > that invalid XML chars don't come through.
>
> Is the pre-commit hook stderr xml-escaped???? I wonder why no one pointed
> that out.... :?
>
that's marshallade as a normal error and errors are XML escaped. (Have you
tested and found out that it isn't the case? In that case, feel free to
correct me!) A test for this is a hook script that outputs some characters
that need to be entities, such as < and &. Might be good to include that
in the test case for this feature.

//Peter

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri May 20 14:42:03 2005

This is an archived mail posted to the Subversion Dev mailing list.