[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r14643 - in trunk/subversion: include libsvn_client libsvn_ra_dav libsvn_repos libsvn_wc

From: Max Bowsher <maxb_at_ukf.net>
Date: 2005-05-09 17:43:17 CEST

Philip Martin wrote:
> "Peter N. Lundblad" <peter@famlundblad.se> writes:
>
>> On Mon, 9 May 2005 kfogel@tigris.org wrote:
>>
>>> Author: kfogel
>>> Date: Mon May 9 01:07:30 2005
>>> New Revision: 14643
>
>>> + * Use @a pool for temporary allocation. For compatibility, if @a pool
>>> + * is @c NULL, then use a new subpool of the global pool for temporary
>>> + * allocation, and destroy the subpool before returning.
>>> + *
>>
>> why not handle this case in the wrapper isntead (by creating a pool and
>> destroying it after the call)? Do we need the NULL pool handling in the
>> new API?
>
> Yes, it would be much better to do it in the wrapper. All the
>
> err = ...
> if (err)
> goto departure;
>
> changes could be reverted, which is a good thing as that style is very
> prone to bugs caused by inadvertent use of SVN_ERR.

Done, but I'm not voting, because I haven't paid attention to any parts of
the change outside svn_subst_translate_stream.

Max.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon May 9 18:23:59 2005

This is an archived mail posted to the Subversion Dev mailing list.