Re: svn commit: r14643 - in trunk/subversion: include libsvn_client libsvn_ra_dav libsvn_repos libsvn_wc

Philip Martin <philip@codematters.co.uk> writes:

> Yes, it would be much better to do it in the wrapper. All the
>
> err = ...
> if (err)
> goto departure;
>
> changes could be reverted, which is a good thing as that style is very
> prone to bugs caused by inadvertent use of SVN_ERR.

I decided to have a look at our existing uses of "goto cleanup", just
to see how many had SVN_ERRs that bypassed the cleanup.

These look like real errors:

- libsvn_wc/adm_crawler.c:svn_wc_crawl_revisions2
  fails to call reporter->abort_report

- libsvn_ra_dav/util.c:parsed_request
  fails to destroy neon structures

- libsvn_fs_base/fs.c:base_create
- libsvn_fs_base/fs.c:base_open
  fails to call cleanup_fs

- libsvn_client/commit.c:svn_client_commit
  fails to call editor->abort_edit

Leaving a subpool isn't really a problem, so these are not bugs:

- libsvn_wc/questions.c:svn_wc_text_modified_p
- libsvn_wc/props.c:svn_wc_props_modified_p
  fails to delete a subpool

I don't understand the significance of this one:

- libsvn_wc/status.c:close_edit
  fails to clear traversal_info

-- 
Philip Martin
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org