[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Hotcopy fix

From: Branko Čibej <brane_at_xbc.nu>
Date: 2005-05-09 14:02:25 CEST

D.J. Heap wrote:

> Does this patch look rational? It behaves correctly for me in my
> testing so far.
>
> Log:
> Fix hotcopy command's handling of the db/format file and the locks table.
>
> In BDB repositories, the format file was never being copied. In FSFS
> repositories, the format file was always being copied which would
> fail on old repositories where that file did not exist.
>
> Additionally, the locks table was never being copied in FSFS
> repositories.
>
> * subversion/libsvn_fs_base/fs.c
> (base_hotcopy): Copy the db/format file if it exists.
>
> * subversion/libsvn_fs_fs/fs_fs.c
> (copy_locks_table): New function to copy the locks table while holding
> the repository write lock.
> (svn_fs_fs__hotcopy): Copy the db/format file and locks table if they
> exist.

The patch looks O.K. at first glance (haven't tested it), but could we
please include tests with such bug fixes?

-- Brane

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon May 9 14:03:31 2005

This is an archived mail posted to the Subversion Dev mailing list.