[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH 2] Allocating large buffers on the stack was: Re: Subversion 1.2.0 RC3 (final candidate) on Monday?

From: Patrick Mayweg <mayweg_at_qint.de>
Date: 2005-05-08 17:19:06 CEST

Hi Erik,

Erik Huelsmann wrote:

>>Patrick Mayweg wrote:
>>
>>
>>>>Hi,
>>>>this patch removes the last of the SVN_STREAM_CHUNK_SIZE buffers from
>>>>the stack and use the pool instead. This fixes the stack overflow for
>>>>the javahl binding on windows. I am not sure if this change is
>>>>permissible, because of the interface change.
>>>>
>>>>
>>No, it is not, for exactly this reason.
>>
>>
>
>But the API *can* be revved...
>
>Which seems to be the right thing to do if it actually is a showstopper to
>use bindings on an otherwise perfectly supported platform.
>
>
If my first patch would be committed, that would get the javahl binding
on windows running again. That decreases the stack needed enough for the
time beeing.

>
>
>>Max.
>>
>>
>
>bye,
>
>Erik.
>
>
>
Regards,
Patrick

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sun May 8 17:22:33 2005

This is an archived mail posted to the Subversion Dev mailing list.