[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: RFE: svn_client_ls() should return locking info

From: Peter N. Lundblad <peter_at_famlundblad.se>
Date: 2005-04-30 18:17:33 CEST

On Sat, 30 Apr 2005, Ben Collins-Sussman wrote:

>
> On Apr 30, 2005, at 9:22 AM, SteveKing wrote:
> >
> Your point about network turnarounds is taken; my first instinct for
> implementing svn_client_ls3() would be to call svn_ra_get_locks()
> internally and add the information to the dirent2_t's it returns. But
> then this would be just as slow as if you did this task yourself.
>
> So the only way to efficiently get lock information is to really change
> both network protocols, so that the lock info came back in the single
> svn_ra_get_dir() network request. (Actually, the ra_svn protocol would
> have to be extended here, but not DAV. ra_dav already asks for a list
> of properties when it does a recursive PROPFIND; it just needs to ask
> for an extra lock property.)
>
I'm afraid we have another problem here. svn_ra_get_locks and
svn_fs_get_locks are recursive operations. In FSFS we could easily allow
depth 1 (or whatever depth we wanted). That's not the case in bdb. Maybe
we choose the bad tradeoff here.

svn_ra_get_dir could do an svn_fs_get_lock (server side) for each entry,
but that's also a slowdown.

Stefan: Another idea. status -u gives you all lock information. Maybe you
could give lock information in whatever in your GUI corresponds to that,
instead of the repo browser?

Regards,
//Peter

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Apr 30 18:10:39 2005

This is an archived mail posted to the Subversion Dev mailing list.