[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Issue #2285

From: Peter N. Lundblad <peter_at_famlundblad.se>
Date: 2005-04-29 23:31:31 CEST

On Wed, 27 Apr 2005 kfogel@collab.net wrote:

> +/*** Helper used by commands other than log. ***/
>
> +svn_error_t *
> +svn_client__ensure_no_log_message (svn_client_ctx_t *ctx,
> + apr_pool_t *pool)
> +{
> + if (ctx->log_msg_func)
> + {
> + const char *message, *tmp_file;
> + apr_array_header_t *commit_items_decoy =
> + apr_array_make (pool, 0, sizeof (svn_client_commit_item_t *));
>
> + SVN_ERR ((*ctx->log_msg_func) (&message, &tmp_file, commit_items_decoy,
> + ctx->log_msg_baton, pool));
> + if (tmp_file || (message && (message[0] != '\0')))
> + return svn_error_createf
> + (SVN_ERR_CL_UNNECESSARY_LOG_MESSAGE, NULL,
> + _("Local, non-commit operations do not take a log message"));
> + }
> +
> + return SVN_NO_ERROR;
> +}

I'm uncomfortable with this idea. It makes invoking the log message func
with 0 commit items mean "don't ask the user, but give me a message if it
was specified by some other means" or something like that. That's not
documented in the API and I don't think we can introduce such a change and
be compatible.

Also, to be honest, I think it is very hacky. Why not just make the
cmdline client check that -F or -m weren't specified when an operation was
invoking without an URL? I don't think libsvn_client should ask for a
message unless it really wants one.

Regards,
//Peter

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Apr 29 23:29:34 2005

This is an archived mail posted to the Subversion Dev mailing list.