Re: [PATCH] Revert and svn:needs-lock

Peter N. Lundblad wrote:
[snip]
>
>
> I think maybe_set_readonly should check for the lock token. That would fix
> other such bugs, such as:
> - svn ci --no-unlock makes the file read-only
> - svn update, when restoring missing working files, they become read-only
> even if they are locked.
>
> I don't know if there are others. Just checked those two cases.
>

Thanks -- I'm out of time to work on it, but this weekend I'll try to
address this and Philip's timestamp concerns.

For reverting, I did try making the maybe_set_readonly call follow the
same path as the executable bit with the magic properties flag -- but
that code doesn't seem to run if the property is deleted entirely. Is
that correct?

Please don't let me hold up anyone with more knowledge fixing this,
though, if they are so inclined.

Thanks,

DJ

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Apr 27 15:56:54 2005