Re: [PATCH] Revert and svn:needs-lock

On Tue, 26 Apr 2005, D.J. Heap wrote:

> Is this better? I guess just looking at entry->lock_token to see if
> they have the lock is sufficient since anything more would require
> contacting the repo, wouldn't it?
>
> Log:
> Make revert restore the 'read-only-ness' of files with the
> svn:needs-lock property if there is no lock token in the
> working copy.
>
> * subversion/libsvn_wc/adm_ops.c
> (revert_admin_things): If we don't have a lock token for the
> file, call svn_wc__maybe_set_read_only to look at the
> svn:needs-lock property and set read-only-ness accordingly.

I think maybe_set_readonly should check for the lock token. That would fix
other such bugs, such as:
- svn ci --no-unlock makes the file read-only
- svn update, when restoring missing working files, they become read-only
even if they are locked.

I don't know if there are others. Just checked those two cases.

Thanks,
//Peter

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Apr 27 08:17:21 2005