[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r14452 - trunk/subversion/libsvn_subr

From: <kfogel_at_collab.net>
Date: 2005-04-26 23:01:05 CEST

Daniel Rall <dlr@finemaltcoding.com> writes:
> >> * subversion/libsvn_subr/io.c
> >> (apr_dir_is_empty): Removed inline comment asking about the
> >
> >Not directly related to this commit, but does anyone know why we have a
> >function with an apr_ name as an internal static? I think it should just
> >be moved inside svn_io_is_empty().
> In r2404, Karl Fogel says:
> * subversion/libsvn_subr/io.c
> (apr_dir_is_empty): Replaces apr_check_dir_empty, declare static.
> Document in APR style, in preparation for move to APR. Rewrite
> body, now check for "." and ".." explicitly. Change calling
> discipline. I love saying that: "calling discipline". There, I
> said it again.
> (svn_io_dir_empty): New function, wrapper for above.

Heh, and this is proof of why we shouldn't do things that way.

Instead, I should have given it an "svn_" prefix, and mentioned in its
doc string what was going on. All of which is now done in r14457.


To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Apr 26 23:32:54 2005

This is an archived mail posted to the Subversion Dev mailing list.