[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r14452 - trunk/subversion/libsvn_subr

From: Daniel Rall <dlr_at_finemaltcoding.com>
Date: 2005-04-26 20:44:56 CEST

On Tue, 2005-04-26 at 20:24 +0200, Peter N. Lundblad wrote:
>On Tue, 26 Apr 2005 dlr@tigris.org wrote:
>
>> Author: dlr
>> Date: Tue Apr 26 12:06:25 2005
>> New Revision: 14452
>>
>> Modified:
>> trunk/subversion/libsvn_subr/io.c
>>
>> Log:
>> * subversion/libsvn_subr/io.c
>> (apr_dir_is_empty): Removed inline comment asking about the
>
>Not directly related to this commit, but does anyone know why we have a
>function with an apr_ name as an internal static? I think it should just
>be moved inside svn_io_is_empty().

In r2404, Karl Fogel says:

* subversion/libsvn_subr/io.c
  (apr_dir_is_empty): Replaces apr_check_dir_empty, declare static.
  Document in APR style, in preparation for move to APR. Rewrite
  body, now check for "." and ".." explicitly. Change calling
  discipline. I love saying that: "calling discipline". There, I
  said it again.
  (svn_io_dir_empty): New function, wrapper for above.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Apr 26 20:47:22 2005

This is an archived mail posted to the Subversion Dev mailing list.