[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r14445 - in trunk/subversion: tests/libsvn_subr

From: Peter N. Lundblad <peter_at_famlundblad.se>
Date: 2005-04-26 07:51:10 CEST

On Mon, 25 Apr 2005 kfogel@collab.net wrote:

> lundblad@tigris.org writes:
> > --- trunk/subversion/libsvn_subr/path.c (original)
> > +++ trunk/subversion/libsvn_subr/path.c Mon Apr 25 15:14:21 2005
> > @@ -711,40 +711,35 @@
> > skip_uri_scheme (const char *path)
> > {
> > apr_size_t j;
> > - apr_size_t len = strlen (path);
> >
> > - /* ### Taking strlen() initially is inefficient. It's a holdover
> > - from svn_stringbuf_t days. */
> > + assert (path);
> >
> > - /* Make sure we have enough characters to even compare. */
> > - if (len < 4)
> > + /* <scheme> has length > 0 and doesn't contain ':' or '/'.
> > + (i.e. the first char is not ':' or '/')
> > + path[1] and path[2] are tested to assert the precondition
> > + of the following loop. */
> > + if (path[0] == '\0' || path[0] == ':' || path[0] == '/'
> > + || path[1] == '\0' || path[2] == '\0')
> > return NULL;
> >
> > - /* Look for the sequence '://' */
> > - for (j = 0; j < len - 3; j++)
> > + for (j = 1; path[j + 2] != '\0'; ++j)
> > {
>
> Still waiting for Greg Hudson to mutter something about cycle
> counting... but I confess I enjoyed this code :-).
>
Yeah, and I waited for a comment like that:-) Note that it was a patch; I
wouldn't have spent time on it except this.

(Sometimes I think it is good to apply patches even if they are very smal
improvements. Maybe it stimulates someone ore than closing an issue as
WONTFIX.)

Regards,
//Peter

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Apr 26 07:44:57 2005

This is an archived mail posted to the Subversion Dev mailing list.