Re: [PATCH] Stop 'svn import' from creating empty revisions (v4)

"C. Michael Pilato" <cmpilato@collab.net> writes:

> "S.Ramaswamy" <ramaswamy@collab.net> writes:
>
> > * subversion/libsvn_client/commit.c
> > (import_ctx_t) : New import context struct suggested by
> > C.Michael Pilato. Currently only the repos_changed boolean
> > is used to remember if changes were made to the repository.
>
> As only the 'repos_changed' is used, it's the only thing that should
> be in the baton. I've tweaked your code to move the other baton
> members into a TODO comment.
>
> The rest of the patch looks fine. I'm testing now, and will probably
> be committing up shortly.

Actually, there is one other complaint. You needn't pass around the
import context baton as a void * -- it's defined in this file, so you
can pass it around as a 'struct import_ctx_t' and not have to futz
with having both "import_ctx" and "imp_ctx". I'll make this tweak,
too.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Apr 18 17:52:51 2005