[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] issue #2224- copy wc path to itself recurses infinitely

From: Peter N. Lundblad <peter_at_famlundblad.se>
Date: 2005-04-15 13:35:07 CEST

On Fri, 15 Apr 2005, Alexander Thomas wrote:

> On Fri, 2005-04-15 at 04:15, John Szakmeister wrote:
>
> > I'm not sure the above is entirely correct. First, svn_path_local_style()
> > only meant to be called on strings that represent local filesystem paths.
> > At this point src_path could be a URL or wc path.
>
> I think, path within error messages should be in local_style
>
Yes, that's the policy if the path is a path on the local computer of the
user (i.e. not an URL or path in the repository filesystem). But if you
change as you proposed below, that's OK. (Converting an URL to local
style on Windows looks very confusing.)

> I feel even to depreciate url-to-url fix from the patch, by editing line
> "if (src_is_url == dst_is_url)" ==> "if (!src_is_url && !dst_is_url)"
>
Regards,
//Peter

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Apr 15 13:29:37 2005

This is an archived mail posted to the Subversion Dev mailing list.