[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] issue #2224- copy wc path to itself recurses infinitely

From: Alexander Thomas <alexander_at_collab.net>
Date: 2005-04-15 12:31:11 CEST

On Fri, 2005-04-15 at 04:15, John Szakmeister wrote:

> I'm not sure the above is entirely correct. First, svn_path_local_style()
> only meant to be called on strings that represent local filesystem paths.
> At this point src_path could be a URL or wc path.

I think, path within error messages should be in local_style

> Secondly, this only covers two cases: wc-to-wc copies, and url-to-url copies.
I feel even to depreciate url-to-url fix from the patch, by editing line
"if (src_is_url == dst_is_url)" ==> "if (!src_is_url && !dst_is_url)"

thus limiting only to wc-to-wc copy into itself.

> It doesn't prevent someone from doing a wc-to-url or a url-to-wc copy into itself.
> I think if we're going to say that you can't copy a directory into
> itself, then we should do this for all cases.

url-to-url or wc-to-url or url-to-wc needs further discussion and I
better leave this here for others to comment.I personally feel to keep
this feature intact.

-Alexander Thomas(AT)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Apr 15 12:32:17 2005

This is an archived mail posted to the Subversion Dev mailing list.