[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Stop 'svn import' from importing empty paths

From: C. Michael Pilato <cmpilato_at_collab.net>
Date: 2005-04-14 16:49:19 CEST

"C. Michael Pilato" <cmpilato@collab.net> writes:

> "S.Ramaswamy" <ramaswamy@collab.net> writes:
> > Changelog:
> >
> > * subversion/libsvn_client/commit.c
> > (repos_change_baton_t) : New struct with a single boolean
> > member to remember if changes were made to the repository.
> >
> So, I like the spirit of the change, but I think you took my
> suggestions too literally. As it turns out, there is no existing
> context baton for import operations. So why not just add
> 'svn_boolean_t *' parameters to all the places you added
> 'repos_change_baton_t *' ones in your patch. We don't to create a
> context baton just to hold one variable. And if we were thinking,
> "Hey, a context baton is easy to grow later should we need to," then
> we should call that thing 'struct import_ctx_t' or something not so
> tied to the "Did-the-repos-change" question.

As a followup, if you wanted to make a generic import ctxt baton, some
good candidates for things that could join "repos_changed" in there

   # The import editor/baton.
   const svn_delta_editor_t *editor;
   void *edit_baton;

   # Client context baton.
   svn_client_ctx_t *ctx;

   # Paths (keys) excluded from the import (values ignored).
   apr_hash_t *excludes;

To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Apr 14 16:54:38 2005

This is an archived mail posted to the Subversion Dev mailing list.