[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r14194 - in trunk/subversion: mod_dav_svn tests/clients/cmdline

From: C. Michael Pilato <cmpilato_at_collab.net>
Date: 2005-04-14 16:06:57 CEST

"Peter N. Lundblad" <peter@famlundblad.se> writes:

> > else if (strcmp(child->name, "limit") == 0)
> > - {
> > - limit = atoi(child->first_cdata.first->text);
> > - }
> > + limit = atoi(child->first_cdata.first->text);
>
> Any particular reason to not fix this one?

The answer to that may be found a bit further up in the patch:

> > Modified: trunk/subversion/mod_dav_svn/log.c
> > Url: http://svn.collab.net/viewcvs/svn/trunk/subversion/mod_dav_svn/log.c?view=diff&rev=14194&p1=trunk/subversion/mod_dav_svn/log.c&r1=14193&p2=trunk/subversion/mod_dav_svn/log.c&r2=14194
> > ==============================================================================
> > --- trunk/subversion/mod_dav_svn/log.c (original)
> > +++ trunk/subversion/mod_dav_svn/log.c Thu Apr 14 03:24:56 2005
                                                           ^^^^^^^^
Ah, yes -- there it is ---------------------------------------'

:-)

Feel free to fix (I'm likely to be dangerous to Subversion's codebase
in my current state) -- I don't think it's backport-worthy (APR seems
to only break up the chunks of CDATA on non-trivial things like
character references and such, which shouldn't be present in the
<limit> element).

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Apr 14 16:12:22 2005

This is an archived mail posted to the Subversion Dev mailing list.