[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] issue #2224- copy wc path to itself recurses infinitely

From: Alexander Thomas <alexander_at_collab.net>
Date: 2005-04-14 12:31:17 CEST

On Thu, 2005-04-14 at 13:59, John Szakmeister wrote:

> It's not an error for someone to want to copy a directory into itself.

what I suggest is to follow unix style.

> * svn_io_copy_dir_recursively() fails to watch for and skip recursing
> into dst_basename while looping through the directory contents, at least
> at the top level (it's actually dst_path + dst_basename that you need to
> filter). :-)

> Do you mind taking a stab at this again? At the very least,
> svn_io_copy_dir_administratively() should be made to work correctly.
>
I will send some time on this, but my strong feeling is to keep it
simple and solve this before it reaches copy_dir_administratively, like
my patch do (i guess so..). 'svn_io_copy_dir_recursively' recurse
infinitely only if 'svn cp' tries to copy wc_path to itself and in other
cases, I hope it's perfect.

Thanks
Alexander Thomas(AT)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Apr 14 12:32:43 2005

This is an archived mail posted to the Subversion Dev mailing list.