[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: revised [PATCH] fix for 'make davautocheck'

From: VK Sameer <sameer_at_collab.net>
Date: 2005-04-14 10:13:31 CEST

Responding to this since Vivek is out today.

On Wed, 2005-04-13 at 22:12, Max Bowsher wrote:

> Defines APXS variable, but does not use it.

It _is_ used in a few places notably when finding the location of httpd.
But a bare apxs was also being used. Fixed.

> Uses both ` ` and $( ). Be consistent.

Good point, fixed.

> Pointless to define a function which is called just once, and that,
> immediately after its definition.


> Please follow the guidelines in HACKING regarding log messages.

Hope the updated log message is ok.


Fix davautocheck.sh failures caused by looking for mod_dav_svn.so
in invalid location. Add authentication directives to httpd
configuration for lock-tests in 'make davautocheck'.

* subversion/tests/clients/cmdline/davautocheck.sh
  APXS: new variable containing apxs or apxs2
  HTPASSWD: new variable for htpasswd
  HTTPD: modified to apxs to locate httpd
  HTTPD_CFG: add authentication directives for locking tests
  HTTPD_USERS: new password file variable
  get_loadmodule_config(): use apxs to find LIBEXECDIR instead of
  hard-coding Apache modules directory

To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Received on Thu Apr 14 10:15:10 2005

This is an archived mail posted to the Subversion Dev mailing list.