Re: revised [PATCH] fix for 'make davautocheck'

Vivek wrote:
>> On Wed, 2005-04-13 at 18:37, Peter N. Lundblad wrote:
>>> On Wed, 13 Apr 2005, Vivek wrote:
>>>
>>>>
>>> Nice to see that you're working on this, since I was also trying to get
>>> this working, to not have to mess up my main Apache installation with
>>> test
>>> stuff.
>>>
>>> On Debian, apxs for Apache 2 is called apxs2. It might be a good idea to
>>> make this script adhere to the --with-apxs config option. Another would
>>> be
>>> to have the script get the Apache binary name from apxs as well.
>>>
>> ok. The script have been modified according to your suggestions. Thanks.
>> And thanks to sameer@collab.net for working with me for all this.

Thanks.

Further issues:

Defines APXS variable, but does not use it.

Uses both ` ` and $( ). Be consistent.

Pointless to define a function which is called just once, and that,
immediately after its definition.

Do not leave old code present but commented out, that's what the history is
for.

Please follow the guidelines in HACKING regarding log messages.

Max.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Apr 13 18:46:21 2005