[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Suppress display of sensitive info by servers (proposal)

From: <kfogel_at_collab.net>
Date: 2005-04-13 20:21:10 CEST

"C. Michael Pilato" <cmpilato@collab.net> writes:
> Man, I hope so. I can't imagine how painful patch application and
> backporting will be if we convert all our svn_error_t's to
> svn_error_t2's.

I would go so far as to say that deciding we must create svn_error2_t
would be a showstopper for this solution. It would be better to go
with some completely different solution, such as using a special
prefix for the custom message in security-sensitive errors, e.g.:

   err = svn_error_createf
         (apr_err, NULL,
          "[SVN:SEC] Revision %d not found in path '%s'",
          rev, path);

Translators would know to leave that part alone, and the caller could
look for that prefix in err->message.

Again, I'm not saying I prefer this kluge to simply tacking a new
field onto the end of 'svn_error_t'. But I'd certainly prefer it to
creating 'svn_error2_t'.

-Karl

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Apr 13 20:50:19 2005

This is an archived mail posted to the Subversion Dev mailing list.