[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r14066 - in trunk/subversion: include libsvn_fs libsvn_fs_base libsvn_fs_fs

From: Peter N. Lundblad <peter_at_famlundblad.se>
Date: 2005-04-11 09:23:25 CEST

On Sat, 9 Apr 2005 ghudson@tigris.org wrote:

> Modified: trunk/subversion/libsvn_fs/fs-loader.c
> Url: http://svn.collab.net/viewcvs/svn/trunk/subversion/libsvn_fs/fs-loader.c?view=diff&rev=14066&p1=trunk/subversion/libsvn_fs/fs-loader.c&r1=14065&p2=trunk/subversion/libsvn_fs/fs-loader.c&r2=14066
> ==============================================================================
> --- trunk/subversion/libsvn_fs/fs-loader.c (original)
> +++ trunk/subversion/libsvn_fs/fs-loader.c Sat Apr 9 06:17:05 2005
> +svn_error_t *
> +svn_fs_initialize (apr_pool_t *pool)
> +{
> + apr_status_t status;
> +
> + common_pool = svn_pool_create (pool);

I think we should protect against multiple calls of this function. Say
that we use libA and libB. Both use libsvn_fs and libAInit and libBInit
both call svn_fs_initialize. If we add the check for common_pool being
non-NULL, we can resolve this situation by calling svn_fs_initialize first
with a pool that we control.

> +#if APR_HAS_THREADS
> + status = apr_thread_mutex_create (&common_pool_lock,
> + APR_THREAD_MUTEX_DEFAULT, common_pool);
> + if (status)
> + return svn_error_wrap_apr (status, "Can't allocate FS mutex");

This message should be localizable. Applies for all eror messages you
introduced.
> +#endif

Else, it looks fine AFAICT (with the later fixes in r140{68,79}.

Regards,
//Peter

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Apr 11 09:18:31 2005

This is an archived mail posted to the Subversion Dev mailing list.